• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add ad_page_contract (fixes automated tests)

Replace ad_decode idioms, improve legibility

Replace ad_decode idioms

    • -2
    • +2
    ./admin/applications/application-add.tcl
Replace ad_decode idiom

Replace ad_decode idioms

Replace ad_decode idioms

  1. … 1 more file in changeset.
Whitespace changes

use consistently 'ad_script_abort' after 'ns_returnfile'

Add missing 'ad_script_abort' after 'ns_returnfile'

Better handling of errors during 'exec convert' in portrait-bits.tcl, returning the default avatar when it fails

Use a variable for the default avatar mime type

Return default avatar also when there are internal issues parsing the user provided picture

fix for bug #3375: set fully qualified url for instance_name

Provide some basic way to create subgroups via the UI

Actually store the group name in the UI by intercepting the right form var

Move logics to delete a group type into the API

    • -79
    • +0
    ./admin/group-types/delete-2-oracle.xql
  1. … 3 more files in changeset.
Fix quoting of group type

Use ad_include_contract for this include page

    • -25
    • +29
    ./admin/groups/elements-by-rel-type.tcl
Fix typos in query

    • -3
    • +3
    ./admin/groups/elements-by-rel-type.tcl
Move some quoting in the api

    • -1
    • +1
    ./admin/groups/elements-by-rel-type.adp
    • -3
    • +8
    ./admin/groups/elements-by-rel-type.tcl
Fix typo: new relation would be added always for the latest segment

    • -1
    • +1
    ./admin/groups/elements-by-rel-type.adp
Replace stored procedures with inline queries and reduce divergency between oracle and postgres codebase

    • -44
    • +0
    ./admin/groups/elements-by-rel-type-oracle.xql
    • -41
    • +0
    ./admin/groups/elements-by-rel-type-postgresql.xql
    • -2
    • +37
    ./admin/groups/elements-by-rel-type.tcl
Fix typos

Recover include intended behavior:

this include was supposedly looking at subgroups of the provided group_id (clearly stated in the doc), while in fact scope was always forcefully set on package_id from the connection

    • -5
    • +2
    ./admin/groups/elements-by-group-type.tcl
Streamline multirow creation

    • -6
    • +6
    ./admin/groups/elements-by-group-type.tcl
Redefine include as ad_include_contract with docs and parameters in the right place

    • -27
    • +31
    ./admin/groups/elements-by-group-type.tcl
Remove unneeded statements

Fix typo

fix for bug #3367 (many thanks to Rainer Bachleitner)

Optimize avatar image size (~30%, using Trimage)