• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
group::party_member_p

- provided a warning, when specified group_id is ignored

- fix dicumentation

- simplify logic

group::get_id_not_cached;

- provide a warning, when subsite overrulese a specified application_group_id

- provide a warning, when multiple groups with the same name exists, but an arbitrary one is returned

- don't ignore specified subsite_id

- remove tests, which are always true

- fix bug in group::get_id: don't ignore application_group_id in case it is provided

Use themed template in template used in user::workspace callback

Complete message keys

Support internationalization via [group::get_member_state_pretty] and

other related messages concerning state changes.

  1. … 5 more files in changeset.
Centralize message handling for member_state management in group::get_member_state_pretty. More can be done, i18n needs to be added as well (required to having a more generalized handling of memberships in acs-admin and acs-subsite/www/members

  1. … 1 more file in changeset.
Fix spelling errors

  1. … 8 more files in changeset.
Preserve trailing slashes in urls specified e.g. UserNavbarTabsList

Fix spelling errors

  1. … 16 more files in changeset.
Improve robustness of "file delete" operations

  1. … 19 more files in changeset.
Add missing namespace (Thanks to Günter Ernst)

In case, a pretty_name was already provided in form of a message key, there is no need to convert this a second time.

Make test more robust on subsequent calls

Theme Manager:

- add local_p flag to subsite-theme:

Distinguish between locally created themes and system themes

(provided via packages)

- the default parameters of local themes can be overwritten

in the database. Therefore, when site contains many subsites,

this makes it easy to share the settings between the subsites,

without the need of creating a new theme package.

- bump version to 5.9.1d11

  1. … 8 more files in changeset.
Add theme manager to admin pages, allowing to

- list current themes with potential modifications

- save modified themes under a new name

- delete themes

  1. … 9 more files in changeset.
- added missing query email_image::new_item.lob_size

- replaced local query by API call "content::item::set_live_revision -revision_id $revision_id"

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 14 more files in changeset.
composition-rel reform:

- apply changes developed by Michael Steigman for making rel-types

configurable whether these should be composable or not

(default is: these are composable, which was up to now the only

choice)

- improved documentation of log argument lists of SQL functions

- Background:

http://openacs.org/forums/message-view?message_id=5330734

http://openacs.org/forums/message-view?message_id=4031049

- bump version number of acs-kernel to 5.9.1d16

  1. … 31 more files in changeset.
- add a subsite::theme_changed callback to be able to handle theme changes in custom themes

  1. … 1 more file in changeset.
- simplify code

- align with postgres

- fix for bug #2962

Bugfix: not possible to define group types over admin interface:

- Remove dependency on "user_objects" in PostgreSQL code: This table

is an interface to Oracle's data dictionary and gives access to all

defined objects (tables, views, functions, packages, ...) and is

used to check, whether code has to be recompiled after some update.

This code check is now deactivated for PostgreSQL for the time

being.

- Without this change, it was not possible to define group

types in postgres over the admin interface (in acs-subsite)

- fix order of words in command

- default_state should be false and not "", otherwise a tcl error will show up

- write sql statements between curly braces

  1. … 12 more files in changeset.
.xql-file reform of acs-subsite:

- remove queries from .tcl files that can't work

from PostgreSQL (e.g. containing "connect by" or "nvl")

- remove obsolete file www/admin/site-map/parameter-set.tcl

  1. … 6 more files in changeset.
.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

    • -11
    • +24
    ./rel-types-procs-postgresql.xql
  1. … 20 more files in changeset.
.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

    • -40
    • +0
    ./application-group-procs-oracle.xql
    • -40
    • +0
    ./application-group-procs-postgresql.xql
  1. … 56 more files in changeset.