• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- add convenience function ad_tmpdir

- replace deprecated ns_tmpnam by ad_tmpdirname or ad_tmpdir

  1. … 3 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
New feature: now one can send plain filesystem files as email attachments, instead than only those into file-storage

  1. … 8 more files in changeset.
- build command for smtp::sendmessage as a list instead of a string (simplifies code, more readable, ... better!)

- improve quoting saftey by using "list" instead of constant braces

- write error message to log file in case smtp::sendmessage raises an error. This way, we try to avoid that a catch on an above calling level swallows silently the error message

- improve variable name

- stop renaming predefined AOLserver/NaviServer command ns_sendmai (for the time migration phase, simply overwrite it)

- replace calls to deprecated "ns_sendmail" to calls to "acs_mail_lite::send"

  1. … 3 more files in changeset.
- simply string expressions

- remove unneeded quoting

- use "in" or not in (ni) operator instead of lsearch

- improve domain guessing for naviserver configurations

  1. … 1 more file in changeset.
if processing of email message causes an error, keep it locked to prevent repeated attempts by sweeper and memory leakage

Don't use the encoded subject in the call to the callback

- guard body from non-positional argument interpretation (many thanks to Franz Penz for the bug fix)

Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

  1. … 214 more files in changeset.
- fix test files__tcl_file_common_errors

- report errors as such in aa-test (wrote warnings into error log, this was ignored since ages)

- fixed naming in acs-tcl, acs-mail-lite and acs-subsite

  1. … 5 more files in changeset.
Implements TIP #140. Rollout support params are package parameters now (instead of config.tcl ones). ns_sendmail is now deprecated but provided as a wrapper to acs_mail_lite::send for backward compatibility.

  1. … 2 more files in changeset.
Added comment to explain Dcc vs Bcc

Rolling back Victor's change. DCC is correct (BCC wouldn't work as expected).

most likely the author meant BCC instead of DCC.

Added rollout support without using ns_sendmail anymore. Beware that the email message will be print out to the log raw, so if there are attachments, they will be print out too.

remove duplicate procs bounce_prefix and address_domain which live in incoming-mail-procs.tcl and bounce-procs.tcl

TIP#127 Add object_id as optional parameter to acs_mail_lite::send

  1. … 3 more files in changeset.
Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

Merged from 5.4.2

  1. … 283 more files in changeset.
Ooops, forgot to rename a variable

Reodered the steps to build the message parts first, then add the headers using mime::setheaders (except To, From, CC and BCC). Retrieve the message as a string only if delivery mode is not set to default (smtp). Tested successfully with tcllib 1.8 and 1.10 (unless I missed something)

After discussion in the OCT, rolled this back. And leave it rolled back.

Fixed problem with complex send not knowing about the new valid_email_p procedure. additionally made sure that no empty header could be passed, as this breaks smtp::sendmail

  1. … 1 more file in changeset.
Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).

Use DCC header instead of the BCC one in call to ::smtp::sendmessage

Move complex_smtp to smtp. Mark ::sendmail and ::deliver_mail as deprecated

  1. … 1 more file in changeset.