Activity OpenACS/openacs-4/packages/acs-lang

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	41
Last Commit:	05 Apr
Commits this week:	0
Total Lines of Code (LoC):	19,392
Net change in LoC this week:	0

Commit Activity

last updated 3 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Friday 12 Apr 2019

3:48 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

- -52
- +27
./www/admin/package-list.xql
- History
- Source
- Diff
./www/admin/package-list.xql

2:49 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

- -28
- +20
./www/admin/package-list.xql
- History
- Source
- Diff
./www/admin/package-list.xql

Thursday 11 Apr 2019

8:36 pm

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

- -4
- +4
./acs-lang.info
- History
- Source
- Diff
./acs-lang.info
- -0
- +1
./catalog/acs-lang.en_US.ISO-8859-1.xml
- History
- Source
- Diff
./catalog/acs-lang.en_US.ISO-8859-1.xml
- -0
- +1
./catalog/acs-lang.es_ES.ISO-8859-1.xml
- History
- Source
- Diff
./catalog/acs-lang.es_ES.ISO-8859-1.xml
- -5
- +6
./www/admin/message-list.tcl
- History
- Source
- Diff
./www/admin/message-list.tcl
- -0
- +1
./www/admin/message-list.xql
- History
- Source
- Diff
./www/admin/message-list.xql
- -0
- +6
./www/admin/package-list.adp
- History
- Source
- Diff
./www/admin/package-list.adp
- -53
- +32
./www/admin/package-list.tcl
- History
- Source
- Diff
./www/admin/package-list.tcl
- -0
- +97
./www/admin/package-list.xql
- History
- Source
- Diff
./www/admin/package-list.xql

8:36 pm

hectorr

More
MAIN:hectorr:20190411183641
deleted 1 file
MAIN

file package-list.xql was initially added on branch oacs-5-10.

- -0
- +0
./www/admin/package-list.xql
- History
- Source
./www/admin/package-list.xql

4:53 pm

hectorr

Fix untranslated count and view on acs-lang 'message-list' + some refactoring

- -20
- +24
./www/admin/message-list.tcl
- History
- Source
- Diff
./www/admin/message-list.tcl
- -1
- +1
./www/admin/message-list.xql
- History
- Source
- Diff
./www/admin/message-list.xql

Tuesday 09 Apr 2019

9:17 pm

hectorr

Fix acs-lang 'admin/message-list' page, making the number of messages in different states coherent, and general refactoring

- -7
- +14
./www/admin/message-list.adp
- History
- Source
- Diff
./www/admin/message-list.adp
- -109
- +72
./www/admin/message-list.tcl
- History
- Source
- Diff
./www/admin/message-list.tcl
- -14
- +66
./www/admin/message-list.xql
- History
- Source
- Diff
./www/admin/message-list.xql

Monday 08 Apr 2019

4:47 pm

hectorr

HTML cleanup

- -4
- +2
./www/admin/message-delete.adp
- History
- Source
- Diff
./www/admin/message-delete.adp
- -4
- +2
./www/admin/message-undelete.adp
- History
- Source
- Diff
./www/admin/message-undelete.adp

4:46 pm

hectorr

Whitespace changes

- -15
- +15
./www/admin/message-list.tcl
- History
- Source
- Diff
./www/admin/message-list.tcl

4:38 pm

hectorr

Fix message key description edition

- -7
- +4
./www/admin/edit-localized-message.tcl
- History
- Source
- Diff
./www/admin/edit-localized-message.tcl

3:24 pm

hectorr

Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

- -0
- +12
./tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-lang-test-procs.tcl
- -2
- +7
./www/admin/message-list.adp
- History
- Source
- Diff
./www/admin/message-list.adp
- -4
- +6
./www/admin/message-list.tcl
- History
- Source
- Diff
./www/admin/message-list.tcl
- -0
- +14
./www/admin/message-undelete.adp
- History
- Source
- Diff
./www/admin/message-undelete.adp
- -0
- +50
./www/admin/message-undelete.tcl
- History
- Source
- Diff
./www/admin/message-undelete.tcl
… 2 more files in changeset.

3:24 pm

hectorr

More
MAIN:hectorr:20190408132437
deleted 1 file
MAIN

file message-undelete.adp was initially added on branch oacs-5-10.

- -0
- +0
./www/admin/message-undelete.adp
- History
- Source
./www/admin/message-undelete.adp

3:24 pm

hectorr

More
MAIN:hectorr:20190408132437:1
deleted 1 file
MAIN

file message-undelete.tcl was initially added on branch oacs-5-10.

- -0
- +0
./www/admin/message-undelete.tcl
- History
- Source
./www/admin/message-undelete.tcl

Friday 05 Apr 2019

2:50 pm

hectorr

Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

- -36
- +66
./tcl/lang-message-procs.tcl
- History
- Source
- Diff
./tcl/lang-message-procs.tcl

Monday 25 Mar 2019

3:16 pm

antoniop

Exclude locales that are not enabled from test

- -1
- +3
./tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-lang-test-procs.tcl

3:06 pm

antoniop

Do not test deleted keys

- -4
- +4
./tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-lang-test-procs.tcl

1:08 pm

antoniop

Display error message when the test fails

- -2
- +3
./tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-lang-test-procs.tcl

Thursday 14 Mar 2019

3:26 pm

antoniop

Update test case for lang::util::default_locale_from_lang

- -16
- +10
./tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-lang-test-procs.tcl

11:41 am

antoniop

Trim padding from column to be sure

- -0
- +3
./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
- History
- Source
- Diff
./sql/oracle/.../upgrade-5.10.0d2-5.10.0d3.sql

11:23 am

antoniop

Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?