• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve handling of invalid (hacked) ad_locale cookies.

Previously, invalid ad_locale cookies lead to an error, which in turn

prevented all communication with OpenACS. So, a user had to delete the

cookie manually. Now, we just produce a warning, ignore and delete such

broken cookies.

  1. … 1 more file in changeset.
Fix for issue #3409

Tolerate wrong locales from browsers by assuming our default one

Remove deprecated proc 'ad_locale_get_label', scheduled to be removed in 5.3, and used nowhere.

Whitespace changes

  1. … 1 more file in changeset.
Harmonize parameter names in proc documentation removing unexistent ones

Delete thread cache variable as well when setting a new locale and use this corrected api to repair broken test

  1. … 1 more file in changeset.
set lang::system::get_locales to per-thead cache as indicated

cache system locales in a per-thread cache

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
remove conditions, which are always true

remove parens

  1. … 5 more files in changeset.
Reduce stress on util_memoize_cache by removing the - by far - most often reused

item in the cache (apm_package_installed_p_not_cached ref-timezones). Instead,

we fall back to the (per-thread) caching of apm_package_id_from_key.

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- fix spelling of variable name

- Make parsing of "Accept-Language" header fields more robust:

ignore spaces after the comma, ignore wildcard value "*"

- Accept locales as syntactically correct when these contain numeric values (such as e.g. "es_419" for “Latin American Spanish”).

Since lang::conn::valid_locale_p is used in lang::conn::get_accept_language_header, OpenACS throws exceptions

on invalid locales, these caused problem even when these are low on the preference list of the Accept-Language header field.

- allow empty locale cookie

- return the invalid cookie in the error

- add validator for locale (useful, when headers or locale-cookie were hacked)

- provide an error message for invalid locale values

- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

  1. … 9 more files in changeset.
- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

  1. … 42 more files in changeset.
Performance improvements for rp_filter and parameter:

- improve performance of rp_filter (which is run on every

non-resources request) significantly (often a factor of 2)

- improve scalability by reducing number of required mutex locks

(e.g. for secret token handling)

  1. … 8 more files in changeset.
Implements TIP#137 Support for 3-chars language codes

  1. … 15 more files in changeset.
Fixes:

1. If user_id = 0, try to retrieve the locale from the cookie. If not, fallback to the system one

2. If the user locale is not set in her preferences, return the system one.

Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Merged acs-core oacs-5-2 (currently 5.2.3) -> HEAD.

TODO:

1. Bump acs-core package version numbers to 5.3.0d1

2. Would be nice to do a test install, wouldn't it?

  1. … 721 more files in changeset.