• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

fix broken API function acs_object_type::get_table_name (broken since 13 years) and use API instead of direct SQL queries

  1. … 7 more files in changeset.
Rework variable assigning loops (set -> lassign)

  1. … 3 more files in changeset.
remove conditiions, which are always true

  1. … 1 more file in changeset.
Fix typos

  1. … 34 more files in changeset.
fix invalid meta-data and documentation strings

fix typos

  1. … 14 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 5 more files in changeset.
Fix spelling errors

  1. … 49 more files in changeset.
Created new proc cr_check_mime_type, centralizing the retrieval of the mime_type from uploaded file's information.

Applied the new proc to the different situations in the system when we require mime_type retrieval: content-repository, file-storage and xotcl CrItem

TODO: get the real mime_type from the file content, but this would require some modification in the data model.

  1. … 7 more files in changeset.
- fix documentation bug (... -revision best ... does not work)

- prefer sql statements between curly braces

  1. … 10 more files in changeset.
Merging back to HEAD all changes that happened in branch oacs-5-8 between tags: vg-merge-oacs-5-8-from-20141027 and vg-merge-oacs-5-8-from-20150427

  1. … 520 more files in changeset.
- fix for issue #3242: for items with a latest_revision but no live_revision, content::item::get_revision_content was raising an exception

- Fix for Bug #3237

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
cleanup in item::* namespace

most functions were already moved into the content::item namespace,

but a few were left.

- marked the following function as deprecated

* item::get_content

* item::content_is_null

* item::get_revision_content

* item::content_methods_by_type

* item::publish

* item::unpublish

- added new functions:

* content::item::content_is_null

* content::item::content_methods_by_type

* content::item::get_content

* content::item::get_revision_content

* content::item::publish

* content::item::unpublish

- updated regression test

  1. … 5 more files in changeset.
- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

- use "eq" instead of "string equal"

  1. … 3 more files in changeset.
- modernize tcl

  1. … 9 more files in changeset.
Make content::item::new is live parameter default to f instead of empty string to match content::revision::new

Make content::item::new is live parameter default to f instead of empty string to match content::revision::new

- remove lock statements, which seem not needed anymore with Postgres 8.2 or newer

  1. … 1 more file in changeset.
Merged 5.3 to HEAD

  1. … 60 more files in changeset.
Bug#3107 Document use of tmp_filename. The caller needs to clean up

the tmp file. The content repository does not "know" what the proper

procedure is to handle the file.

  1. … 1 more file in changeset.
Major cleanup of item-procs, replaced DB calls by calls to content::item::* in 18

of the 24 deprecated procs, just six procs are still required. Commented most

of the affected calls in ::content::item::*

  1. … 4 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Indention fixes

Adding image API

  1. … 2 more files in changeset.
Fix for the duplicate revision_id and deadlock on concurrent cr updates and inserts

  1. … 5 more files in changeset.