Activity OpenACS/openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	23
Last Commit:	23 Apr
Commits this week:	0
Total Lines of Code (LoC):	2,039
Net change in LoC this week:	0

Commit Activity

last updated 15 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Friday 15 Sep 2023

10:53 am

trenner

In case the user used an external_registry for login, we have to allow the redirect to a complete url

- -2
- +4
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Sunday 14 May 2023

1:09 pm

gustafn

External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

- -14
- +34
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 3 more files in changeset.

Sunday 27 Nov 2022

7:08 pm

gustafn

improve spelling

- -3
- +3
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 4 more files in changeset.

Wednesday 20 Apr 2022

10:00 am

antoniop

Specify the empty value correctly in the authentication form fields

- -2
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Thursday 10 Feb 2022

10:33 pm

gustafn

fixes for Oracle 19c

- -2
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 5 more files in changeset.

Monday 01 Nov 2021

11:41 am

gustafn

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

- -22
- +6
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Friday 09 Apr 2021

7:17 pm

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

- -16
- +16
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

4:01 pm

antoniop

Make proc public, as was intended

- -2
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Thursday 08 Apr 2021

6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

- -7
- +11
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 1 more file in changeset.

5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

- -3
- +20
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 2 more files in changeset.

Tuesday 30 Mar 2021

5:58 pm

hectorr

Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

- -2
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Friday 26 Mar 2021

3:43 pm

hectorr

Make 'auth::get_register_authority' public, as it is used by acs-subsite

- -2
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Tuesday 23 Mar 2021

2:16 pm

hectorr

Make 'auth::verify_account_status' public, as it is used in other packages. Fixes 'callgraph__bad_page_calls' test case

- -4
- +2
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

Thursday 11 Mar 2021

3:26 pm

hectorr

Use the new 'url' and 'email' input type widgets

- -3
- +3
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl
… 1 more file in changeset.

Wednesday 03 Mar 2021

4:06 pm

antoniop

Port of downstream logic: do not use a hardcoded list of local authorities, but rather check if the authority implementation is local, which would handle also other downstream local authorities

Rework the idiom to perform cheap checks first and improve documentation

- -9
- +20
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

1:35 pm

antoniop

Fix var name

- -5
- +5
./authentication-procs.tcl
- History
- Source
- Diff
./authentication-procs.tcl

12:25 pm

antoniop

Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally"

Fixes acs-authentication.auth_use_email_for_login_p automated test