• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

  1. … 4 more files in changeset.
Replace array idioms with dict idioms, streamline expressions

Trim whitespace

improve testcases by removing useless expr commands

  1. … 17 more files in changeset.
improve rowcount expressions

  1. … 71 more files in changeset.
Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 28 more files in changeset.
Update es_ES catalog files

    • -0
    • +1
    ./catalog/acs-admin.es_ES.ISO-8859-1.xml
  1. … 1 more file in changeset.
Bump version number so new message key is loaded

Trim whitespace

Provide a localized "Creation date" message in english, german and italian

    • -0
    • +1
    ./catalog/acs-admin.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-admin.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-admin.it_IT.ISO-8859-1.xml
Fix typos

  1. … 11 more files in changeset.
improve spelling

  1. … 27 more files in changeset.
apm reloading reform (part 2)

adjust version-reload and align version numbers

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 366 more files in changeset.
Use @return in the proc documentation

  1. … 2 more files in changeset.
Prefer on-spot api for user-only info

Prefer on-spot api as it is quicker

acs_user::get will not fail anymore with non-existing user

Prefer person-only api to generic user one as is quicker and now properly cached

Prefer on-spot api rather than full-blown acs_user::get

Fix after regression by putting subsite url retrieval... ehm... before its usage

revert to previous version, since "Administration" links were plain wrong (not pointing to SUBSITE/admin but to a constant url)

permission check reform (part 1): provide API for permission cache

    • -4
    • +6
    ./www/users/modify-admin-privileges.tcl
  1. … 15 more files in changeset.
Remove divergency between oracle and postgres codebase

    • -22
    • +0
    ./lib/service-parameters-oracle.xql
    • -22
    • +0
    ./lib/service-parameters-postgresql.xql
  1. … 3 more files in changeset.
Remove leftover xql files

    • -23
    • +0
    ./www/users/modify-admin-privileges-oracle.xql
    • -23
    • +0
    ./www/users/modify-admin-privileges-postgresql.xql
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Use api to remove difference between oracle and postgres code and replace array with dict idioms

Remove leftover xql files

remove outdated file, maintained version of the code is in the function apm_build_repository