• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix after regression by putting subsite url retrieval... ehm... before its usage

revert to previous version, since "Administration" links were plain wrong (not pointing to SUBSITE/admin but to a constant url)

permission check reform (part 1): provide API for permission cache

  1. … 16 more files in changeset.
Remove leftover xql files

    • -23
    • +0
    ./users/modify-admin-privileges-oracle.xql
    • -23
    • +0
    ./users/modify-admin-privileges-postgresql.xql
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Use api to remove difference between oracle and postgres code and replace array with dict idioms

Remove leftover xql files

remove outdated file, maintained version of the code is in the function apm_build_repository

Make all sql in this page portable and inline

remove unreferences and broken files depending on data model changed more than 10 years ago

Fix regression when checking member state

removing uncalled pages based on non-existing tables and on deprecated calls

Use more api

Exploit cached api to simplify and remove queries. Note that user attributes this page manipulates won't come from the cache to avoid nasty side effects. Reduce divergency between oracle and postgres codebase

    • -13
    • +0
    ./users/member-state-change-oracle.xql
    • -16
    • +0
    ./users/member-state-change-postgresql.xql
Exploit cached api

Reduce divergencies between oracle and postgres codebase... this file was for some reason deleted in 2001, but sql in it is portable

    • -18
    • +0
    ./users/registration-history-oracle.xql
    • -19
    • +0
    ./users/registration-history-postgresql.xql
Remove (again) this almost 20 years old program

    • -73
    • +0
    ./users/sessions-registered-summary.tcl
Remove unneded xql

Use more API when retrieving user info

Use more API

  1. … 2 more files in changeset.
Rework adp boolean expressions

  1. … 25 more files in changeset.
perform proper boolean test (variable ends with "_p")

Prefer literal in adp axpressions + Whitespace changes

  1. … 27 more files in changeset.
Simplify SQL expression

Remove questionable not-working code

This page was apparently unreachable from the UI, relied on a table that

does not exist anymore (apm_package_files) and was supposedly meant to

"interact" with the CVS...

Remove questionable not-working code

This page was apparently unreachable from the UI, relied on a table that

does not exist anymore (apm_package_files) and was supposedly meant to

"interact" with the CVS by writing stuff in the files...

Farewell to "Lars Hack"

  1. … 1 more file in changeset.
Remove unused query mentioning a table not part of the datamodel anymore. Remove inline sql in the tcl file as xql version is available

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 468 more files in changeset.
Rework variable assigning loops (set -> lassign) + Whitespace changes

    • -18
    • +17
    ./apm/version-dependency-add-2.tcl
  1. … 12 more files in changeset.