• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Prefer person-only api to generic user one as is quicker and now properly cached

Prefer on-spot api rather than full-blown acs_user::get

permission check reform (part 1): provide API for permission cache

  1. … 16 more files in changeset.
Remove leftover xql files

    • -23
    • +0
    ./modify-admin-privileges-oracle.xql
    • -23
    • +0
    ./modify-admin-privileges-postgresql.xql
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Fix regression when checking member state

removing uncalled pages based on non-existing tables and on deprecated calls

Exploit cached api to simplify and remove queries. Note that user attributes this page manipulates won't come from the cache to avoid nasty side effects. Reduce divergency between oracle and postgres codebase

    • -16
    • +0
    ./member-state-change-postgresql.xql
Exploit cached api

Reduce divergencies between oracle and postgres codebase... this file was for some reason deleted in 2001, but sql in it is portable

    • -19
    • +0
    ./registration-history-postgresql.xql
Remove (again) this almost 20 years old program

Remove unneded xql

Use more API when retrieving user info

Use more API

  1. … 2 more files in changeset.
Rework adp boolean expressions

  1. … 25 more files in changeset.
Prefer literal in adp axpressions + Whitespace changes

  1. … 29 more files in changeset.
improve documentation

  1. … 10 more files in changeset.
remove conditions, which are always true

  1. … 3 more files in changeset.
strengthen page contracts

  1. … 15 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

  1. … 31 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 20 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 24 more files in changeset.
User ad_try instead of "with*"

Get rid of obsolete query (portable version in generic xql already)

Reduce divergence between postgres and oracle codebase

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
Replace /acs-admin/users/one links with acs_community_member_admin_url

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7820 more files in changeset.
provide default for email_verified_p

- Don't name valdation black and formal argument the same