• last updated 43 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
harden page contracts

  1. … 22 more files in changeset.
skip "-url" in "export_vars -url" since it is the default

  1. … 11 more files in changeset.
Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 5 more files in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

  1. … 4 more files in changeset.
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

  1. … 4 more files in changeset.
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
remove conditions, which are always true

  1. … 3 more files in changeset.
Reduce divergence between postgres and oracle codebase

  1. … 3 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Make sure, return_url for complex-user-search works as well for other contexts

- prefer sql statements between curly braces

  1. … 16 more files in changeset.
- allow no-selected group in user search (by fixing other bugs, db_html_select_value_options works now, but forced the user to select a group)

- use a faster sql query

  1. … 2 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
- improve validity and saftey of HTML

  1. … 18 more files in changeset.
- improve validity and security of HTML of admin pages

  1. … 15 more files in changeset.
- use type checking for boolean parameters in page_contracts to improve security

  1. … 29 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- check ids in page contracts

  1. … 36 more files in changeset.
- not need to check for existence of variables with defaults: email, first_names, limit_to_users_in_group_id authority_id last_name_starts_with

- fix spelling limit_users_in_group_id -> limit_to_users_in_group_id

  1. … 1 more file in changeset.
- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

  1. … 121 more files in changeset.
- make use of byte-compiled functions

  1. … 13 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Let complex user search users in a specific authority

- Merged to HEAD.

  1. … 1 more file in changeset.
- Remove upper from order by to make it work under PG 7.3.

Bug 598, patch 223 by Gabriel Durca. Thanks.

merge of 4.6.3b1 to HEAD

  1. … 101 more files in changeset.
Sorting user list, and fixed formatting

  1. … 1 more file in changeset.
Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 33 more files in changeset.