• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged with the 4.5 branch (oacs-4-5 tag "don-merge-1")

  1. … 52 more files in changeset.
Focus first input field on forms (SDM #1500).

Missing context bar on bboard index page (SDM #1498). This was due to the <if @context_bar@ not nil> check in the master template.

Merged with OpenACS 4.5 beta1 branch.

  1. … 85 more files in changeset.

Removed references to registering child types, which is done by general

comments these days.

Bug fix by Bart Teeuwisse: category name function was improperly ported.

Applied Tilman Singer's patch that changes template <if> tag checks from

"ne 0" to the more meaningful "eq false", etc.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

    • -9
    • +18
    ./sql/postgresql/bboard-packages.sql
    • -29
    • +24
    ./tcl/bboard-procs-postgresql.xql
  1. … 61 more files in changeset.
fix bug that didn't allow for null charters

make it obvious that null charters are allowed

fix bug to allow for null charters

fix bug that dosen't allow null charters

fix "cellpadding" typo that was causing bboard message list table to be very cluttered.

Fixed some errors in my earlier hacking on hierarchical queries...

  1. … 3 more files in changeset.

Added code to make use of David Walker's wonderfully abusive hack on the

pg_proc table that showed me how to write recursive SQL functions. We now

have good use of the index on tree_sortkey when climbing the tree, woo-hoo!

  1. … 17 more files in changeset.

Oops - I'd previously committed a query with a literal substituted for

:forum_id, done back when I was hacking these queries for greater efficiency

using real test data. I was using psql so I was using literal values...

Changed the representation of tree_sortkeys from "text" to "bit varying".

    • -3
    • +10
    ./www/message-delete-2-postgresql.xql
  1. … 57 more files in changeset.

Changed to the new tree_sortkey comparison scheme. Mostly untested (yet)

will do so shortly!

    • -16
    • +12
    ./tcl/bboard-procs-postgresql.xql
    • -11
    • +6
    ./www/message-move-2-postgresql.xql

1. Replaced more "tree_sortkey like" with "tree_sortkey between" expressions

2. Fixed a bad port of an Oracle query in site-nodes-procs.tcl and removed

a needless outer join from both versions in the process.

  1. … 11 more files in changeset.

Check the comments in postgresql.sql - my previous commit didn't quite work

as expected.

I also removed an ugly assumption made in the PG port in bboard-procs.tcl.

  1. … 1 more file in changeset.

Added "tree_left" and "tree_right" in order to optimize tree queries, which

I did for the bboard package. "LIKE (tree_sortkey || %)" never uses the

index as we thought it did, as it turns out ... see postgresql.sql for

example queries that do.

  1. … 1 more file in changeset.

First round of speedups for verious permissions issues. Key finding is that

the all_object_party_privilege_map is speedy in PostgreSQL and apparently in

Oracle, as well (having re-read some of the optimization threads).

    • -12
    • +16
    ./tcl/bboard-procs-postgresql.xql
  1. … 18 more files in changeset.

Added a comment to this file ...

1. Fixed a boneheaded error in the bootstrapper: "AvailablePool" was being

submitted to a case-sensitive check. Of course AOLserver parameters are

case-insensitive.

2. A recently submitted patch to the db routine that PSQL's source broke

the code if you haven't started postmaster with the "-i" option.

3. Bboard was very, very slow in PG. It is now much faster.

    • -47
    • +13
    ./sql/postgresql/bboard-views.sql
  1. … 2 more files in changeset.

1. Modified the Javascript "check/uncheck all boxes" code in the APM

package install page so that it still works if javascript's disabled.

2. Slight rewrite of a view in bboard.

3. Skin works in OpenACS Oracle/PG - changed info file to reflect this.

4. Added clean error handling to wimpy point attachment upload page.

  1. … 3 more files in changeset.

Bug fixes in the postgres ports of these packages ...

  1. … 2 more files in changeset.

1. Added a new Tcl procedure to the content repository's library, named

cr_write_content, which properly writes content to the connection

regardless of RDBMS and storage type. This simplified a bunch of stuff

(which explains the removed files).

2. Fixed a lot of general comments issues regarding HTML vs. Plain/Text,

attachments, etc.

3. Partially ported glossary.

    • -15
    • +12
    ./tcl/bboard-procs-postgresql.xql
  1. … 75 more files in changeset.
added name method support for content_revision type

  1. … 5 more files in changeset.

Fixed all sorts of cruft uncovered when I decided to fix the bug preventing

file upload in bboard.

  1. … 3 more files in changeset.
Don't use db_dml when calling stored procs. Use db_exec_plsql instead.