• last updated 51 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bug #128 - Fixes for paginator of search package (navbar)

- Prevent double encoding of query string

- Include csrf token

    • -7
    • +9
    /openacs-4/packages/search/lib/navbar.tcl
    • -1
    • +1
    /openacs-4/packages/search/www/search.adp
changes for install from repository:

- change labeling of list filter:

* show current channel version (instead of just "current")

* call selector for head packages not "head" but supplemental

- offer on "head" channel just these packages, which are not available

in the current channel (this avoids a potential damage in the

current installation, when somebody tries e.g. to install

a core package from head, which is broken and/or older than

packages in the current channel). Since there is no way to downgrade

packages in OpenACS, such errors might be hard to fix.

- use message keys instead of hard-coded strings for maturity in

www/install/install.tcl

- provide a long description for maturity_deprecated

- remove duplicated maturity entry

- compute .apm files as well for -final releases (starting with OpenACS 5.8)

- call validator as well, when no user_id is explicitly specified ("... -require user_id" in validator filters default case)

- be silent, when specified element does not exist

- replace onfocus/onblur with "placeholder"

- revert this mornings change.

- revert this mornings change, since this leads to many warnings

- use for hex codes 2-digit notation \xHH to make it compatible for tcl8.6

- add resolver for explicitly spefified "-href ..." infos in image links

    • -3
    • +12
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
- fix typo in HTML text

-remove quotes in text

- use event listener

- provide width&height of images to speed up rendering

Use id of the including page when includlet doesn't have its own

- improve comment

- use same uplevel idiom everywhere (many thanks to antonio)

- add conditional search field to adp-generator

- make sure to set ids (should go probably into constructor)

- change special markers in text_to_html from \x001 and \x002 to \u0002 (start of text) and \u0003 (end of text). The previous coding did not work always reliably, regsub was missing some entries, probably due to a mess-up of the internal representation.

- bug-fix (old bug): not sure, why "proc" was removed from the @see tag. the consequence was, that "@see ad_proc" as converted into "ad_", which is incorrect (see occurence e.g. in http://openacs.org/api-doc/proc-view?proc=callback&source_p=1)

- fixing a probably old bug: changed the markers in ad_text_to_html since the old markers with the funy camel case led to problems (at least with current regexp implementations)

in the text below, only 5 of the 8 urls were correctly transformed into anchor markup. The new markers uses uniqe single char starting and ending marker, marking also regexp much simpler.

- the function is further generalized (unifying http/https/ftp urls with mailto urls) and probably faster

A welcome contribution would be e.g. an extension of the api-browser for callbacks (listing contracts/implementations, etc.).

[1] http://openacs.org/api-doc/proc-view?proc=callback&source_p=1

[2] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/search/tcl/search-procs.tcl#L309

[3] https://github.com/openacs/forums/blob/master/tcl/forums-callback-procs.tcl#L104

[4] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-tcl/tcl/apm-procs.tcl

[5] http://openacs.org/api-doc/proc-view?source_p=1&proc=apm_arg_names_for_callback_type

[6] https://github.com/openacs/xowiki/blob/oacs-5-9/tcl/xowiki-callback-procs.tcl

[7] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-subsite/tcl/subsite-callback-procs.tcl#L69

[8] https://github.com/openacs/xotcl-core/blob/oacs-5-9/tcl/06-param-procs.tcl#L386

- fix variable name

- fix typo

- remove erroneous warnings

- reduce the number of regsub operations in ad_text_to_html

- improve/fix souce code comments

- add istener only, when search is configured

Removed use of deprecated ns_ssl API for Naviserver versions newer than 4.99.12

Removed use of util_memoize in favor of ns_memoize

- nsproxy handling: switch back to previous directory in after changing to a new one (which might be deleted before the next call)

    • -1
    • +13
    /openacs-4/packages/acs-tcl/tcl/proxy-procs.tcl