• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix broken links and regenerate documentation

  1. … 111 more files in changeset.
Improve message

make field host_node_id optional to improve backward compatibility

add handling of host_node_id

modernize adp include

Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing

    • -0
    • +1
    /openacs-4/packages/chat/www/html-chat.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/room-delete-2.tcl
Prevent user from triggering db error by entering too big subjects

simplify idiom

Fix cases of this portlet being called on trees without categories.

Modernize list assign idioms

fix broken links

Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

    • -11
    • +43
    /openacs-4/packages/chat/tcl/chat-procs.tcl
- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

fix broken links

Fix broken link

Fix broken link

Make sure message exists when dealing with a banned user

Deal with Mauricio's NaviServer modification (fixes issue #3319)

fix broken links

Update documentation (e.g. fix broken links)

  1. … 133 more files in changeset.
- make policy3 more consistent and better usable with workflows

    • -9
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Ease debugging of policyies and streamline check_permissions with enforce_permissions

Return an error if dependency is missing.

This happens if the (info file of the) required package is not present.

This solution is a bit dirty, but better than throwing the tcl error

"no such variable: spec_file"

Add another constraint name variant as it existed in our production system

Fix constraint name

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

Update construct to reload a page, as previous one was not working properly at least on Chrome and Explorer

- add optional parameter host_node_id (for future use)

- Reflow overlong lines

- fix bug for obtaining logout_url on host-node mapped subsites

- factor out security::get_register_subsite to streamline behavior of ad_get_login_url and ad_get_logout_url

Improve UI for Hostnode map so it is feasible on sites with many nodes to show navigate the site structure

Modernize code (use ad_include_contract instead of manual checks)