• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

Use the attachment icon, available since 10+ years, for forums attachments.

web-callable method list: add optional parameter "children" to allow listing of arbitrary children of an item

move logic whether or not to use h264 streaming to ad_returnfile_background to make code path clearer

reduce verbosity

Make sure, the pull-down login window does not hide under navbar

(e.g. when xowiki menubar is shown)

Modernize logic for protecting against cached passwords from forms,

when users log out and other users use the back button (for Nora).

- switch to more modern caching prevention

- add CSRF protection to login form against forgery requests

- none of the cache-preventing mechanisms helps when the user

stores the password in the browser (no change to the past).

- For admins of existing sites: alter kernel parameter

"LoginPageExpirationTime" to 0 make use of this feature

fix lookup of links for external commands: avoid lookup of page-realtive links (starting with "#")

Fix for issue #3409

add missing colon

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
implementing feature request #3408: support for passing in null values to acs_object__set_attribute

file upgrade-5.10.0d19-5.10.0d20.sql was initially added on branch oacs-5-10.

Use same capitalization policy as other message keys in the same form. Bump version to reload message keys.

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
Only show the possibility to allow/disallow attachments in the forum new/edit pages if the attachments package is already mounted under the forums package instance

    • -3
    • +16
    /openacs-4/packages/forums/lib/forums/new.tcl
Update italian localization

Whitespace changes

    • -3
    • +3
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -12
    • +12
    /openacs-4/packages/forums/tcl/form-procs.tcl
    • -2
    • +2
    /openacs-4/packages/forums/tcl/forums-procs.xql
Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -3
    • +5
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -3
    • +6
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -2
    • +3
    /openacs-4/packages/forums/tcl/forums-procs.xql
Cleanup trailing whitespace

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

    • -2
    • +19
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -3
    • +5
    /openacs-4/packages/forums/www/message-post.tcl
Fix oracle upgrade, remembering to keep privilege creation, which should indeed happen in the upgrade

Skip column and attribute creation in this upgrade: people will get it from xotcl ORM in version 6.* and this upgrade would conflict

Use Duden-conformant Formulation

there are many other terms, which would have do be changed

for general gender neutrility, unless we continue to stick with the

generic masculine.

https://de.wikipedia.org/wiki/Generisches_Maskulinum

https://de.wikipedia.org/wiki/Geschlechtergerechte_Sprache

provide a default for pass_through option

Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

    • -5
    • +5
    /openacs-4/packages/forums/forums.info
file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

Trailing whitespace cleanup

Use 'ckfinder::file_attach' instead of 'ckfinder::image_attach', which is not implemented.

Make doc and logging consistent with implementation (image_attach -> file_attach)

Fix translation

Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done