• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve comment

align to the usual naming convention (use "_not_cached" suffix)

mark uncalled function as deprecated

revert escaped debug output

    • -5
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
streamline and extend test cases for resolving in composite items and in preview workflows

    • -3
    • +8
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
streamline substitution handling

Perform same substitutions as in other test-item workflows.

improve robustness for partial exams

Address issue with .SELF. references in exams (xowf)

Since it is the goal of the exams to store all resources directly

under the questions, handling extra .SELF. references (which are

inserted by a downstream plugin for CKeditor) do not make sense. A

probably cleaner solution to this is to configure the CKeditor

to omit the .SELF. references in these cases.

    • -8
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix typo in message key, many thanks to Monika Andergassen

Make the test stricter: name the files all different so that their existance in the src of an img tag is certain for each of them

Cleanup redundant definition

Fix regression: do not issue the call when there are no headers

added test case for SELF referemce

address (partly) the issue with .SELF. links in exams

    • -3
    • +20
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Added convenience function ::xowiki::test::get_content

This function eases testing by just retrieving the content part of a

page, leaving out header and footers of the theme.

whitespace changes

improve spelling

extended regression test

- show difference between [[image:...]] and [[.SELF./image ...]]

- cleanup test

cleanup test

use more compact idioms, remove useless code, etc.

Extend xowiki.create_test_items automated test:

in the content of questions, use .SELF. references which should point to images stored underneath the question itself. Show that when the questions are used inside of exams, the .SELF. reference will currently not be resolved to the question and result in an unresolved link.

protect against invalid data

added a test for checking the results of the preview of test-items

Since the preview workflow requires a multiple redirects, xowiki::test::edit_form_page

requires a new flag refetch to actually turn off automatic refetching of the result

page, since this does not give us access to the redirect location returned by

the edit command.

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
include item_id in result dict of ::xowiki::test::create_form_page

this makes it possible to perform further checks without refetch by name

fixed test case

returned violation on plain instance

added test case for composite test item

New automated test for a page, including another page, which includes a picture, checking that everything works as expected

output warning message, in case form constraints could not be parsed

    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Differentiate the case of a field being a repeat field or a "normal" coumpound field: in the first case, the whole 'internal' should be converted regardless of the number of components, in the latter, keep the previous behavior

Fixes xowiki create_form_with_numeric after regression in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20220117174044

    • -4
    • +0
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
fix broken regression test

VS: ----------------------------------------------------------------------

Do not apply the new convert_to_external to repeat fields, stick with the previous behavior

Fixes xowiki create_form_with_form_instance automated test

    • -0
    • +4
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl