• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
prefer built-in ns_dbquotevalue over DoubleApos

improve spelling

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Fix @param names

    • -4
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
improve spelling

    • -2
    • +2
    /openacs-4/packages/categories/www/doc/o.adp
use consistently bind variables

improve spelling

improve spelling

port all former tclwebtest test cases to acs::test and do some more detailed testing

    • -3
    • +3
    /openacs-4/packages/forums/forums.info
    • -116
    • +57
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
acs-automated testing:

- provide the ability to add detail urls to messages

- new convenince methods

acs::test::reply_contains

acs::test::reply_contains_no

Fix spelling

Improve the list of common typos for the 'documentation__check_typos' test case, including some from Wikipedia: https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Remove apparent leftover + trailing whitespace

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

add tested API calls to testcases

modernize Tcl

    • -8
    • +12
    /openacs-4/packages/forums/www/forum-view.tcl
display testd URLs on testcases for web tests

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

remove useless semicolon

Streamline proc

Trim whitespace

- modularize web tests based on acs::test

- add new web tests for viewing and editing forums

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -0
    • +143
    /openacs-4/packages/forums/tcl/test/webtest-procs.tcl
- move new testing function "visualize_control_chars" to the namespace ::acs::test

- new testing functions

acs::test::get_form and

acs::test::xpath::get_form

to get collected form info with more ease in test cases

- bump version info to 5.10.0d7

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

Fix Test Name

Add test for the news aggregator and feed-parser

news-aggregator will reuse basic test from the feed parser

Fix subscription form error (left behind from previous commit)

no reason for casting values to integer

Use 'expr' for variable incrementing when the value is a double, as incr does not do it natively (thanks to Antonio for the pointer).

Trim whitespace