Activity OpenACS/

2:15 pm

gustafn

More
MAIN:gustafn:20180719121519
changed 18 files
MAIN

improve testcases by removing useless expr commands

- -3
- +7
/openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-admin-procs.tcl
- -19
- +19
/openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-authentication-procs.tcl
- -21
- +21
/openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sync-test-procs.tcl
- -3
- +3
/openacs-4/packages/acs-content-repository/tcl/test/acs-content-repository-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-content-repository-procs.tcl
- -2
- +2
/openacs-4/packages/acs-content-repository/tcl/test/content-folder-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-folder-test-procs.tcl
- -10
- +10
/openacs-4/packages/acs-content-repository/tcl/test/content-image-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-image-test-procs.tcl
- -15
- +15
/openacs-4/packages/acs-content-repository/tcl/test/content-item-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-item-test-procs.tcl
- -2
- +2
/openacs-4/packages/acs-content-repository/tcl/test/content-keyword-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-keyword-test-procs.tcl
- -6
- +6
/openacs-4/packages/acs-content-repository/tcl/test/content-revision-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-revision-test-procs.tcl
- -4
- +4
/openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-search-procs.tcl
- -7
- +7
/openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-lang-test-procs.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-subsite-procs.tcl
- -11
- +11
/openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl
- History
- Source
- Diff
/openacs-4/.../spell-checker-procs.tcl
- -2
- +2
/openacs-4/packages/dotlrn-ecommerce/tcl/test/dotlrn-ecommerce-procs.tcl
- History
- Source
- Diff
/openacs-4/.../dotlrn-ecommerce-procs.tcl
- -5
- +5
/openacs-4/packages/dotlrn-fs/tcl/test/dotlrn-fs-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../dotlrn-fs-procs.tcl
… 3 more files in changeset.

1:46 pm

gustafn

More
MAIN:gustafn:20180719114657
changed 3 files
MAIN

make tested procs explicit

- -6
- +9
/openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-api-browser-procs.tcl
- -10
- +101
/openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-authentication-procs.tcl
- -15
- +94
/openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sync-test-procs.tcl

1:43 pm

gustafn

More
MAIN:gustafn:20180719114318
changed 6 files
MAIN

improve testcases by removing useless expr commands

- -3
- +3
/openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-tcl-test-procs.tcl
- -7
- +7
/openacs-4/packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../ad-proc-test-procs.tcl
- -14
- +14
/openacs-4/packages/acs-tcl/tcl/test/application-data-link-procs.tcl
- History
- Source
- Diff
/openacs-4/.../application-data-link-procs.tcl
- -3
- +6
/openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../doc-check-procs.tcl
- -16
- +16
/openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
- History
- Source
- Diff
/openacs-4/.../test-permissions-procs.tcl
- -5
- +5
/openacs-4/packages/acs-tcl/tcl/test/whos-online-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../whos-online-procs.tcl

1:42 pm

gustafn

More
MAIN:gustafn:20180719114205
changed 1 file
MAIN

make feedback from testruns nicer (remove redundant messages)

- -10
- +8
/openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/aa-test-procs.tcl

1:17 pm

antoniop

More
MAIN:antoniop:20180719111753
changed 1 file
MAIN

Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../datamodel-test-procs.tcl

12:17 pm

gustafn

More
MAIN:gustafn:20180719101731
changed 1 file
MAIN

flush per-request cache (fixes regression test properly)

- -1
- +6
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

12:16 pm

gustafn

More
MAIN:gustafn:20180719101656
changed 1 file
MAIN

simplify code

- -3
- +2
/openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-tcl-apm-procs.tcl

11:59 am

gustafn

More
MAIN:gustafn:20180719095934
changed 2 files
MAIN

improve testcase viewing page:

- use syntax highlighting to testcase body

- fix label for body:

* just use numbering when appropriate

* start numbering of bodies with 1

- -2
- +3
/openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
- History
- Source
- Diff
/openacs-4/packages/.../admin/testcase.adp
- -12
- +11
/openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/testcase.tcl

11:55 am

gustafn

More
MAIN:gustafn:20180719095512
changed 1 file
MAIN

improve test cases: align comment with operations, remove useless "expr" commands

- -25
- +26
/openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-tcl-apm-procs.tcl

11:52 am

gustafn

More
MAIN:gustafn:20180719095242
changed 1 file
MAIN

improve log message to be able to distinguish between multiple commands with different parameters

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl

11:09 am

antoniop

More
MAIN:antoniop:20180719090918
changed 1 file
MAIN

Make string_truncate behave as before (looking for spaces at end_position + 1) and therefore not breaking tests for ad_html_text_convert. Update docs so this property of being less or equal than len is clearly specified

- -13
- +5
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl

10:20 am

antoniop

More
MAIN:antoniop:20180719082004
changed 1 file
MAIN

Revert change... more investigation needed

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

9:59 am

antoniop

More
MAIN:antoniop:20180719075907
changed 1 file
MAIN

Trim whitespace

- -34
- +33
/openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-cache-procs.tcl

9:57 am

antoniop

More
MAIN:antoniop:20180719075713
changed 1 file
MAIN

node_id shoudl probably be parent_id (fixes automated tests)

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

9:45 am

antoniop

More
MAIN:antoniop:20180719074554
changed 1 file
MAIN

Trim whitespace

- -10
- +10
/openacs-4/packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../site-nodes-test-procs.tcl

12:33 am

gustafn

More
MAIN:gustafn:20180718223325
changed 3 files
MAIN

improve startuptime for large sites

- -1
- +1
/openacs-4/packages/xowf/tcl/xowf-init.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowf-init.tcl
- -1
- +3
/openacs-4/packages/xowf/tcl/xowf-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowf-procs.tcl
- -0
- +4
/openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowf-test-procs.tcl

8:54 pm

hectorr

More
MAIN:hectorr:20180718185423
changed 1 file
MAIN

Whitespace cleanup

- -22
- +22
/openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
- History
- Source
- Diff
/openacs-4/.../html-conversion-procs.tcl

8:51 pm

hectorr

More
MAIN:hectorr:20180718185117
changed 1 file
MAIN

Add '-equal' parameter to 'string_truncate', which allows to truncate a string to a length shorter or *equal* than a specified length.

The fact that 'string_truncate' was producing strings strictly shorter than the specified length, was making the behavior of 'ad_html_text_convert' inconsistent, and breaking automated tests.

This small addition fixes both the behavior and the tests, while retaining compatibility.