OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 May 2018
4:15 pm

antoniop

Modernize tcl

Options
    • -64
    • +51
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-postgresql.tcl
2:21 pm

antoniop

Add extension to UI images

when website is behind a proxy, proxy server migtht not be smart enough to resolve images without extension

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/index.adp
1:56 pm

antoniop

Follow the "ugly" smell

rework of general-comments rendering so that the templating system is used, instead of handcrafted markup. Also, allow theming in the future.

Options
    • -0
    • +33
    /openacs-4/packages/general-comments/lib/comments.adp
    • -96
    • +0
    /openacs-4/packages/general-comments/tcl/general-comments-procs-oracle.xql
    • -101
    • +0
    /openacs-4/packages/general-comments/tcl/general-comments-procs-postgresql.xql
    • -124
    • +61
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
    • -33
    • +4
    /openacs-4/packages/general-comments/tcl/general-comments-procs.xql
1:50 pm

antoniop

Check if file exists or no file descriptor will be created

Options
    • -1
    • +5
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
12:17 am

hectorr

Fix typos + Whitespace changes

Options
    • -23
    • +23
    /openacs-4/packages/categories/www/cadmin/tree-map-2.tcl
    • -3
    • +3
    /openacs-4/packages/categories/www/cadmin/tree-usage.tcl
Tuesday 15 May 2018
11:41 pm

hectorr

Fix typos

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include.tcl
    • -2
    • +2
    /openacs-4/packages/calendar/sql/oracle/calendar-create.sql
    • -2
    • +2
    /openacs-4/packages/calendar/sql/oracle/upgrade/upgrade-1.0-2.0d1.sql
    • -1
    • +1
    /openacs-4/packages/glossary/sql/oracle/glossary-drop.sql
    • -1
    • +1
    /openacs-4/packages/glossary/sql/postgresql/glossary-drop.sql
    • -1
    • +1
    /openacs-4/packages/lors-central/tcl/test/lors-central-procs.tcl
    • -1
    • +1
    /openacs-4/packages/lors-central/www/lc-admin/grant.tcl
    • -1
    • +1
    /openacs-4/packages/lors-central/www/lc-admin/revoke.tcl
    • -3
    • +3
    /openacs-4/packages/monitoring/sql/oracle/cassandracle.sql
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
11:20 pm

hectorr

Fix capitalization

Options
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/css-list.tcl
    • -1
    • +1
    /openacs-4/packages/contacts/tcl/contacts-import-procs.tcl
    • -1
    • +1
    /openacs-4/packages/news/www/news.adp
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
6:32 pm

gustafn

add themeing support for templated footers

Options
    • -1
    • +3
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
3:32 pm

gustafn

add sample regression test cases

Options
    • -0
    • +227
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
3:28 pm

gustafn

whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
3:27 pm

gustafn

add interface for processing html files via xpath interface

Options
    • -2
    • +20
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
3:25 pm

gustafn

white space changes

Options
    • -185
    • +184
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
3:25 pm

gustafn

allow access via automated testing also via standard login interface

Options
    • -6
    • +30
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
2:29 pm

antoniop

Small improvement of css-edit triggered by "ugly" code smell

Options
    • -13
    • +7
    /openacs-4/packages/acs-developer-support/www/css-edit.tcl
1:41 pm

antoniop

Remove obsolete table apm_package_db_types: this was superseded by threaded cache ::acs::known_database_types

Options
    • -24
    • +0
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -15
    • +1
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -0
    • +5
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
    • -15
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
    • -0
    • +5
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
Monday 14 May 2018
5:14 pm

antoniop

Removed unused sql

Options
    • -8
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-procs.xql
5:11 pm

antoniop

Deprecate proc apm_pretty_name_for_db_type as is not used anywhere and also relies on questionable datamodel

Options
    • -14
    • +25
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
4:48 pm

antoniop

Remove unused query mentioning a table not part of the datamodel anymore. Remove inline sql in the tcl file as xql version is available

Options
    • -17
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
    • -17
    • +1
    /openacs-4/packages/acs-admin/www/apm/version-view.xql
3:22 pm

gustafn

make spelling of names more consistent

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl
3:21 pm

gustafn

site-nodes cache reform: use ns_urlsspace instead of brute-force caching.

For OpenACS site with recent versions of NaviServer and XOTcl2,

cache sitenode information much more efficiently by the built-in

URL trie, which supports tree match operations, for

tree information. This means that for example for .vuh

handlers it is not necessary to cache the full url for

obtaining the site-node, like it was until now:

3839 id-/storage/view/installers/windows-installer/installer.htm

3839 id-/storage/view/aolserver/install.tgz

3839 id-/storage/view/tutorial/OpenACS_Tutorial.htm

3839 id-/storage/view/openacs-dotlrn-conference-2007-spring/Methodology_ALPE.pdf

3839 id-/storage/view/xowiki-resources/Assessment.jpg

3839 id-/storage/view/tutorial-page-map.png

...

Providing a single entry like

ns_urlspace set -key sitenode /storage/* 3839

is sufficient.

Why is this needed: current cache sizes of larger sites show 330K

(site A) and 390K (site B) cache entries. Matchbase flushes have to

gor thhrough all these entries, causing long lock times. Running

thhis code at OpenACS.org shows an improvement by a factor of more

than 200x.

Options
    • -1
    • +29
    /openacs-4/packages/acs-tcl/tcl/site-nodes-init.tcl
    • -252
    • +343
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
3:14 pm

antoniop

Use proper thread cached variables instead of legacy proc

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
2:49 pm

antoniop

Deprecate proc 'apm_db_type_keys' as the info it provides is already in 'ad_known_database_types' without need for queries

TODO: find out if we really need a table of database types

Options
    • -11
    • +19
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -7
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.xql
Friday 11 May 2018
11:16 am

antoniop

Improve indentation, use non indentation-breaking idioms to create report string

TODO: refactor this bug-tracker dependency outside the core, e.g. using a callback

Options
    • -112
    • +113
    /openacs-4/packages/acs-tcl/lib/page-error.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/monitor.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/apm/build-repository.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/apm/packages-install.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-reload.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install.tcl
    • -7
    • +7
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/content-page-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/display-sql.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/index.tcl
    • -4
    • +4
    /openacs-4/packages/acs-api-browser/www/package-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/proc-browse.tcl
  16. … 461 more files in changeset.
12:11 pm

antoniop

Reduce query duplication

Options
    • -15
    • +2
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-oracle.xql
    • -16
    • +2
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql
    • -3
    • +5
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl
10:17 am

hectorr

Prefer indivudual 'set' operations over 'lassign' in this case.

Options
    • -2
    • +4
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl
12:39 am

hectorr

Rework variable assigning loops (set -> lassign)

Options
    • -3
    • +2
    /openacs-4/packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl
12:37 am

hectorr

Rework variable assigning loops (set -> lassign) + Whitespace changes

Options
    • -18
    • +17
    /openacs-4/packages/acs-admin/www/apm/version-dependency-add-2.tcl
    • -4
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-i18n-process.tcl
    • -2
    • +1
    /openacs-4/packages/acs-authentication/lib/local-search.tcl
    • -3
    • +1
    /openacs-4/packages/acs-bootstrap-installer/db-init-checks-oracle.tcl
    • -3
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -192
    • +190
    /openacs-4/packages/acs-content-repository/tcl/publish-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
    • -87
    • +85
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
    • -5
    • +4
    /openacs-4/packages/acs-lang/www/admin/lookup.tcl
    • -7
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -4
    • +2
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl
    • -5
    • +3
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -36
    • +35
    /openacs-4/packages/acs-tcl/tcl/pools-init.tcl
Tuesday 08 May 2018
11:16 pm

hectorr

Prefer 'lset' to 'lreplace'.

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl
10:46 pm

hectorr

Prefer string operators to 'string equal'.

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/build-repository.tcl
    • -5
    • +5
    /openacs-4/packages/acs-templating/tcl/test/date-procs.tcl