Activity OpenACS/

4:48 pm

antoniop

More
MAIN:antoniop:20180514144809
changed 2 files
MAIN

Remove unused query mentioning a table not part of the datamodel anymore. Remove inline sql in the tcl file as xql version is available

- -17
- +3
/openacs-4/packages/acs-admin/www/apm/version-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm/version-view.tcl
- -17
- +1
/openacs-4/packages/acs-admin/www/apm/version-view.xql
- History
- Source
- Diff
/openacs-4/packages/.../apm/version-view.xql

3:22 pm

gustafn

More
MAIN:gustafn:20180514132224
changed 6 files
MAIN

make spelling of names more consistent

- -3
- +3
/openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
- History
- Source
- Diff
/openacs-4/.../form-processing-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../navigation-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl
- History
- Source
- Diff
/openacs-4/.../utilities-procs-aolserver.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl
- History
- Source
- Diff
/openacs-4/.../utilities-procs-naviserver.tcl

3:21 pm

gustafn

More
MAIN:gustafn:20180514132152
changed 2 files
MAIN

site-nodes cache reform: use ns_urlsspace instead of brute-force caching.

For OpenACS site with recent versions of NaviServer and XOTcl2,

cache sitenode information much more efficiently by the built-in

URL trie, which supports tree match operations, for

tree information. This means that for example for .vuh

handlers it is not necessary to cache the full url for

obtaining the site-node, like it was until now:

3839 id-/storage/view/installers/windows-installer/installer.htm

3839 id-/storage/view/aolserver/install.tgz

3839 id-/storage/view/tutorial/OpenACS_Tutorial.htm

3839 id-/storage/view/openacs-dotlrn-conference-2007-spring/Methodology_ALPE.pdf

3839 id-/storage/view/xowiki-resources/Assessment.jpg

3839 id-/storage/view/tutorial-page-map.png

...

Providing a single entry like

ns_urlspace set -key sitenode /storage/* 3839

is sufficient.

Why is this needed: current cache sizes of larger sites show 330K

(site A) and 390K (site B) cache entries. Matchbase flushes have to

gor thhrough all these entries, causing long lock times. Running

thhis code at OpenACS.org shows an improvement by a factor of more

than 200x.

- -1
- +29
/openacs-4/packages/acs-tcl/tcl/site-nodes-init.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-init.tcl
- -252
- +343
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

3:14 pm

antoniop

More
MAIN:antoniop:20180514131408
changed 1 file
MAIN

Use proper thread cached variables instead of legacy proc

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-file-procs.tcl

2:49 pm

antoniop

More
MAIN:antoniop:20180514124921
changed 2 files
MAIN

Deprecate proc 'apm_db_type_keys' as the info it provides is already in 'ad_known_database_types' without need for queries

TODO: find out if we really need a table of database types

- -11
- +19
/openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-file-procs.tcl
- -7
- +0
/openacs-4/packages/acs-tcl/tcl/apm-file-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../apm-file-procs.xql

11:16 am

antoniop

More
MAIN:antoniop:20180511091612
changed 1 file
MAIN

Improve indentation, use non indentation-breaking idioms to create report string

TODO: refactor this bug-tracker dependency outside the core, e.g. using a callback

- -112
- +113
/openacs-4/packages/acs-tcl/lib/page-error.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/page-error.tcl

5:33 pm

hectorr

More
MAIN:hectorr:20180509153328
changed 476 files
MAIN

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).