• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate proc 'apm_db_type_keys' as the info it provides is already in 'ad_known_database_types' without need for queries

TODO: find out if we really need a table of database types

Improve indentation, use non indentation-breaking idioms to create report string

TODO: refactor this bug-tracker dependency outside the core, e.g. using a callback

    • -112
    • +113
    /openacs-4/packages/acs-tcl/lib/page-error.tcl
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 461 more files in changeset.
Reduce query duplication

Prefer indivudual 'set' operations over 'lassign' in this case.

Rework variable assigning loops (set -> lassign)

Rework variable assigning loops (set -> lassign) + Whitespace changes

    • -36
    • +35
    /openacs-4/packages/acs-tcl/tcl/pools-init.tcl
Prefer 'lset' to 'lreplace'.

Prefer string operators to 'string equal'.

Rework string comparison expression

Rework list operations

Add 'aggregation_format' option to list template (many thanks to Felix Moedritscher)

put the correct function into upgrade script

Replace 'linsert' with 'lappend'

Fix linsert command argument expansion + Whitespace

Replace 'exists_and_not_null'

Replace deprecated proc 'ad_parameter' with 'parameter::get'

Replace deprecated proc 'empty_string_p'

image width information in table images seems flaky. since portrait-bits provides efficient

scaling, why not use it?

increase number of accepted sizes

improve CSP in accordance with Google's csp-evaluator.withgoogle.com

imporve spelling

fix typo

Replace obsolete function bitfromint4() by cast

make spelling more uniform

reduce verbosity

improve list operations

make spelling more consistent

regenerated documentation

  1. … 14 more files in changeset.
improve list operations